[Lldb-commits] [PATCH] D87694: [lldb] Don't send invalid region addresses to lldb server

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 16 01:25:13 PDT 2020

labath added inline comments.

Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1710
How about adding `return false` here to avoid indenting the code below?

Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:44-52
+        # Test that when the address fails to parse, we do not carry on
+        # and ask lldb-server for an invalid address
+        interp.HandleCommand("memory region not_an_address", result)
+        self.assertFalse(result.Succeeded())
+        self.assertRegexpMatches(result.GetError(),
+                "error: invalid address argument \"not_an_address\"")
+        # This would be found if we carried on despite the error
If you're goal is to ensure that lldb-server is really not queried, then this would require a different kind of a test.

But if (as I suspect), you just want to ensure the error message makes sense, then it would be better to just match the full text of the error message, and drop all references to lldb-server.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list