[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

[António Afonso via Phabricator via lldb-commits]

aadsm added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2265-2267
+    auto base_address = func_range.GetBaseAddress();
+    if (base_address.IsSectionOffset() &&
+        base_address.GetSection()->GetType() == eSectionTypeCode) {
----------------
clayborg wrote:
> This is a bit more expensive than comparing against the m_first_code_address like we do in D87172. We could just modify the "if" statement on line 2256:
> 
> ```
> if (lowest_func_addr >= m_first_code_address && 
>     lowest_func_addr != LLDB_INVALID_ADDRESS &&
>     lowest_func_addr <= highest_func_addr) {
> ```
yeah, I was not expecting to matter that much since it's only 2 function calls?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87173/new/

https://reviews.llvm.org/D87173