[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

[António Afonso via Phabricator via lldb-commits]

aadsm added inline comments.


================
Comment at: lldb/unittests/SymbolFile/DWARF/Inputs/test-invalid-offsets.yaml:520
+          Data:            0
+...
----------------
clayborg wrote:
> aadsm wrote:
> > I generated this yaml with the code that is at the top, and then changed it to replicate the bug ,here's what the line table looks like:
> > 
> > 
> > ```
> > Address            Line   Column File   ISA Discriminator Flags
> > ------------------ ------ ------ ------ --- ------------- -------------
> > 0x0000000100000f80      1      0      1   0             0  is_stmt
> > 0x0000000100000f84      2      5      1   0             0  is_stmt prologue_end
> > 0x0000000100000f8b      2      5      1   0             0  is_stmt end_sequence
> > 0x0000000100000f90      5      0      1   0             0  is_stmt
> > 0x0000000100000f90      5      0      1   0             0  is_stmt end_sequence
> > 0x000000000000000f      2     13      1   0             0  is_stmt prologue_end
> > 0x0000000000000014      2      9      1   0             0
> > 0x0000000000000017      3     12      1   0             0  is_stmt
> > 0x000000000000001d      3     12      1   0             0  end_sequence
> > ```
> > 
> > Now that I think about it maybe I should also copy this into this file as a comment.
> Would line table work just fine without your fix since the good address comes first? Or do we end up with multiple locations? I thought I remembered you thinking that it would pick the first one. Am I remembering correctly?
yeah, I was wrong, they end up being order by address, so the issue is there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87172/new/

https://reviews.llvm.org/D87172