[Lldb-commits] [lldb] ddcc7ce - [lldb-vscode] Fix TestVSCode_module

[Walter Erquinigo via lldb-commits]

Author: Walter Erquinigo
Date: 2020-09-03T09:01:56-07:00
New Revision: ddcc7ce59150c9ebc6b0b2d61e7ef4f2525c11f4

URL: https://github.com/llvm/llvm-project/commit/ddcc7ce59150c9ebc6b0b2d61e7ef4f2525c11f4
DIFF: https://github.com/llvm/llvm-project/commit/ddcc7ce59150c9ebc6b0b2d61e7ef4f2525c11f4.diff

LOG: [lldb-vscode] Fix TestVSCode_module

Caused by D86662. The fix is only checking some fields when the expect_debug_info_size flag is true. For some reason this was not failing on a local linux machine.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py b/lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py
index db70e4a8124b..7fa5f7d45267 100644
--- a/lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py
+++ b/lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py
@@ -38,7 +38,8 @@ def run_test(self, symbol_basename, expect_debug_info_size):
         def checkSymbolsLoadedWithSize():
             active_modules = self.vscode.get_active_modules()
             program_module = active_modules[program_basename]
-            symbolsStatus = program_module['debugInfoSize']
+            self.assertIn('symbolFilePath', program_module)
+            self.assertIn(symbols_path, program_module['symbolFilePath'])
             symbol_regex = re.compile(r"[0-9]+(\.[0-9]*)?[KMG]?B")
             return symbol_regex.match(program_module['symbolStatus'])
                 
@@ -48,8 +49,6 @@ def checkSymbolsLoadedWithSize():
         program_module = active_modules[program_basename]
         self.assertEqual(program_basename, program_module['name'])
         self.assertEqual(program, program_module['path'])
-        self.assertIn('symbolFilePath', program_module)
-        self.assertIn(symbols_path, program_module['symbolFilePath'])
         self.assertIn('addressRange', program_module)
 
     @skipIfWindows