[Lldb-commits] [lldb] 0e86f39 - [lldb/test] Fix TestPlatform*.py Windows failures (NFC)

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 2 12:42:11 PDT 2020


Author: Med Ismail Bennani
Date: 2020-09-02T21:41:35+02:00
New Revision: 0e86f390457a2b4dd1f2d1770db912963a36f240

URL: https://github.com/llvm/llvm-project/commit/0e86f390457a2b4dd1f2d1770db912963a36f240
DIFF: https://github.com/llvm/llvm-project/commit/0e86f390457a2b4dd1f2d1770db912963a36f240.diff

LOG: [lldb/test] Fix TestPlatform*.py Windows failures (NFC)

This patch fixes the windows failures introduced by `addb514`:
http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/18671/steps/test/logs/stdio

This macro, used in the test to check the platform, was missing a `_`,
making the test behave like it was run from a UNIX platform.

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>

Added: 
    

Modified: 
    lldb/test/API/commands/platform/basic/myshell.c

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/platform/basic/myshell.c b/lldb/test/API/commands/platform/basic/myshell.c
index d1c0eecb943e..8fef648de651 100644
--- a/lldb/test/API/commands/platform/basic/myshell.c
+++ b/lldb/test/API/commands/platform/basic/myshell.c
@@ -8,7 +8,7 @@ int main(int argc, char *argv[]) {
     exit(1);
   }
 
-#ifdef WIN32
+#if defined(_WIN32) || defined(_WIN64)
   char *cmd_opt = "/C";
 #else
   char *cmd_opt = "-c";


        


More information about the lldb-commits mailing list