[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 2 09:47:19 PDT 2020


JDevlieghere added a comment.

In D86996#2252520 <https://reviews.llvm.org/D86996#2252520>, @JDevlieghere wrote:

> In D86996#2252246 <https://reviews.llvm.org/D86996#2252246>, @labath wrote:
>
>> I agree that silly, but maybe the same fix should then be applied to the `expr` command (and any other command with similar behavior).
>
> Sure, we can use the same trick in other places that use `OptionsWithRaw`. I'll do that in a separate patch.

Actually, after discussion this with @teemperor offline, for the `expo` command we can't use that trick because a valid option might also be a valid expression. `expr --flag` would parse correctly if flag was an option, but it might also be an expression that decrements `--flag`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86996/new/

https://reviews.llvm.org/D86996



More information about the lldb-commits mailing list