[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 31 13:50:07 PDT 2020


JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Utility/Reproducer.cpp:337
+  } else {
+    llvm::consumeError(symbol_files.takeError());
+  }
----------------
teemperor wrote:
> Maybe log the error to llvm::errs? Or is there no symbol-files.yaml when the replay doesn't involve symbol files, so this is expected?
Correct, the symbol files are optional. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86497/new/

https://reviews.llvm.org/D86497



More information about the lldb-commits mailing list