[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

[Harmen Stoppels via Phabricator via lldb-commits]

haampie updated this revision to Diff 288864.
haampie added a comment.
Herald added a subscriber: danielkiss.

Another take on this isuse, incorporating @phosek's comment on making find_library not find shared libs when compiling with `LLVM_BUILD_STATIC=ON`, and making sure that `get_system_libname` does not add empty items to a regex capture group, as CMake's regex engine does not support this.

@gkistanova, can you test this on your build bot with the static llvm build?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85820/new/

https://reviews.llvm.org/D85820

Files:
  compiler-rt/cmake/config-ix.cmake
  compiler-rt/lib/xray/tests/CMakeLists.txt
  lldb/source/Core/CMakeLists.txt
  llvm/CMakeLists.txt
  llvm/cmake/config-ix.cmake
  llvm/include/llvm/Config/config.h.cmake
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/Unix/Process.inc
  llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85820.288864.patch
Type: text/x-patch
Size: 9114 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200830/8d5912ed/attachment-0001.bin>