[Lldb-commits] [PATCH] D86652: [lldb] Fix ProcessEventData::DoOnRemoval to support multiple listeners

[Ilya Nozhkin via Phabricator via lldb-commits]

ilya-nozhkin added a comment.
Herald added a subscriber: danielkiss.

I've realized that I just didn't know about stop hooks... So, sorry and thanks, it solves almost all my problems except for notifying about "resume" events which are important for me too. But I can use synchronous `Process::Notifications` to receive them (I couldn't use `Notifications` to receive stop events because they are sent before the public state is changed by `DoOnRemoval`). But then I thought why don't we just move `SynchronouslyNotifyStateChanged` invocation from `ShouldBroadcastEvent` to `DoOnRemoval`? It would provide the most convenient way of receiving process events without intersections with the primary listener. I can make these changes in another patch instead of this one.

In D86652#2244043 <https://reviews.llvm.org/D86652#2244043>, @labath wrote:

> This primary listener technique could be implemented purely in your own code, could it not?

I am trying to write an extension that can work with such things as lldb-vscode and lldb-mi without disturbing them. They use default `Debugger`'s listener. So, I can't change the code of this listener on my side thus I can't force them to notify my listener.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86652/new/

https://reviews.llvm.org/D86652