[Lldb-commits] [PATCH] D86670: [intel-pt] Add a basic implementation of the dump command

[walter erquinigo via Phabricator via lldb-commits]

wallace updated this revision to Diff 288751.
wallace added a comment.
Herald added subscribers: dang, danielkiss.

Addressed comments

- Now the "dump" command specifically refers to the currently selected thread. That will be aligned with the future stepping commands we will be adding.
- The format of the command is "trace dump [-t tid]"
- The verbose option is used to dump the original JSON settings
- For now, I'm printing the trace file of each thread. Eventually we'll have more information about each thread.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86670/new/

https://reviews.llvm.org/D86670

Files:
  lldb/include/lldb/Target/Target.h
  lldb/include/lldb/Target/Trace.h
  lldb/source/Commands/CommandObjectTrace.cpp
  lldb/source/Commands/Options.td
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
  lldb/source/Target/Target.cpp
  lldb/source/Target/Trace.cpp
  lldb/test/API/commands/trace/TestTraceDump.py
  lldb/test/API/commands/trace/TestTraceLoad.py
  lldb/test/API/commands/trace/intelpt-trace/trace2.json

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86670.288751.patch
Type: text/x-patch
Size: 15859 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200829/b7aa083d/attachment.bin>