[Lldb-commits] [PATCH] D86825: [lldb/Gui] zero-initialize children_stop_id

[Jordan Rupprecht via Phabricator via lldb-commits]

rupprecht created this revision.
Herald added subscribers: lldb-commits, danielkiss.
Herald added a project: LLDB.
rupprecht requested review of this revision.
Herald added a subscriber: JDevlieghere.

This is currently causing msan warnings in the API tests when run under msan, e.g. `commands/gui/basic/TestGuiBasic.py`.

I'm not sure if 0 is the right initial value, but the tests pass with it (and msan doesn't complain anymore).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86825

Files:
  lldb/source/Core/IOHandlerCursesGUI.cpp


Index: lldb/source/Core/IOHandlerCursesGUI.cpp
===================================================================
--- lldb/source/Core/IOHandlerCursesGUI.cpp
+++ lldb/source/Core/IOHandlerCursesGUI.cpp
@@ -1507,8 +1507,9 @@
   std::vector<Row> children;
 
   Row(const ValueObjectSP &v, Row *p)
-      : value(v, lldb::eDynamicDontRunTarget, true), parent(p), row_idx(0),
-        x(1), y(1), might_have_children(v ? v->MightHaveChildren() : false),
+      : value(v, lldb::eDynamicDontRunTarget, true), parent(p),
+        children_stop_id(0), row_idx(0), x(1), y(1),
+        might_have_children(v ? v->MightHaveChildren() : false),
         expanded(false), calculated_children(false), children() {}
 
   size_t GetDepth() const {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86825.288731.patch
Type: text/x-patch
Size: 735 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200829/e5b1e685/attachment.bin>