[Lldb-commits] [PATCH] D86745: [lldb/test] Use @skipIfWindows for PExpectTest

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 28 00:43:19 PDT 2020


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks like it could work, though only barely. `@skipIfWindows` checks for target system, but we would really need this to check the host OS (for remote testing, although I don't know if anyone does that on windows these days). However, in conjuction with `@skipIfRemote` it should do the right thing. In any case, this is small enough a change to try it out. Just be sure to check the windows bot afterwards.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86745/new/

https://reviews.llvm.org/D86745



More information about the lldb-commits mailing list