[Lldb-commits] [PATCH] D86662: Simplify Symbol Status Message to Only Debug Info Size

[walter erquinigo via Phabricator via lldb-commits]

wallace requested changes to this revision.
wallace added a comment.
This revision now requires changes to proceed.

For the record, this came out of discussion in which the consensus was to display less characters and maximize the relevant information, which in this case is just the debug info size.



================
Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:35
         self.assertTrue('symbolFilePath' not in program_module, 'Make sure a.out.stripped has no debug info')
-        self.assertEqual('Symbols not found.', program_module['symbolStatus'])
+        # self.assertEqual('Symbols not found.', program_module['symbolStatus'])
         symbols_path = self.getBuildArtifact(symbol_basename)
----------------
remove this line instead of commenting 


================
Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:43
             symbolsStatus = program_module['symbolStatus']
-            symbol_regex = re.compile(r"Symbols loaded. \([0-9]+(\.[0-9]*)?[KMG]?B\)")
+            # symbol_regex = re.compile(r"Symbols loaded. \([0-9]+(\.[0-9]*)?[KMG]?B\)")
+            symbol_regex = re.compile(r"[0-9]+(\.[0-9]*)?[KMG]?B")
----------------
same here


================
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:389
+      std::string debug_info_size = ConvertDebugInfoSizeToString(debug_info);
+      object.try_emplace("symbolStatus", debug_info_size);
     }
----------------
rename this field to "debugInfoSize"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86662/new/

https://reviews.llvm.org/D86662