[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

[Raphael Isemann via Phabricator via lldb-commits]

teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.

As discussed offline, I think the warnings here seem also useful when just replaying. I guess we should make it clear that things like missing files are fine when replaying a reproducer (e.g., just pointing that out as a 'note' and not warning/error). Beside that this LGTM.



================
Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:146
+
+/// Create a loader form the given path if specified. Otherwise use the current
+/// loader used for replay.
----------------
`form` -> `from`


================
Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:156
+    if (Error err = loader->LoadIndex()) {
+      // This is a hard error and will set the result tot eReturnStatusFailed.
+      SetError(result, std::move(err));
----------------
`tot` -> `to`


================
Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:603
+                            "If no reproducer is specified during replay, it "
+                            "dumps the content of the current reproducer.",
+                            nullptr) {}
----------------
Is that dumping implemented? It's also kind of surprising that `verify` dumps the current reproducer instead of verifying it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86497/new/

https://reviews.llvm.org/D86497