[Lldb-commits] [PATCH] D86603: [lldb] Correct wording of EXP_MSG

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a reviewer: LLDB.
teemperor added a comment.

If you look at the other "assert messages" above and below your patch you'll see that all (most?) of them use this very confusing "Say the opposite of what actually happened" style. Weirdly enough only around 70% of the "assertion messages" in the test suite are using this style, the others are using an "unexpected thing has happened" error message.

IMHO we should just completely remove all these assertion messages. Not once have they been useful to me when debugging a test. I would argue that 99% of them don't add any additional information that isn't obvious when looking at the assert itself. They also are usually just making the assertions longer and harder to read. Even worse, when I started hacking on LLDB they were often even suppressing the *actual error* which made it impossible to debug a test on a build bot (but that is thankfully fixed these days). And finally the fact that they can be worded in these two different ways just ends up causing confusion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86603/new/

https://reviews.llvm.org/D86603