[Lldb-commits] [PATCH] D86211: [lldb] Don't ask for QOS_CLASS_UNSPECIFIED queue in TestQueues

[Raphael Isemann via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG7de7fe5d0e3f: [lldb] Don't ask for QOS_CLASS_UNSPECIFIED queue in TestQueues (authored by teemperor).
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86211/new/

https://reviews.llvm.org/D86211

Files:
  lldb/test/API/macosx/queues/TestQueues.py
  lldb/test/API/macosx/queues/main.c


Index: lldb/test/API/macosx/queues/main.c
===================================================================
--- lldb/test/API/macosx/queues/main.c
+++ lldb/test/API/macosx/queues/main.c
@@ -136,15 +136,9 @@
             while (1)
                 sleep (10);
       });
-    dispatch_async (dispatch_get_global_queue(QOS_CLASS_UNSPECIFIED, 0), ^{
-            pthread_setname_np ("unspecified QoS");
-            atomic_fetch_add(&thread_count, 1);
-            while (1)
-                sleep (10);
-      });
 
     // Unfortunately there is no pthread_barrier on darwin.
-    while ((atomic_load(&thread_count) < 13) || (finished_enqueueing_work == 0))
+    while ((atomic_load(&thread_count) < 12) || (finished_enqueueing_work == 0))
         sleep (1);
 
     stopper ();
Index: lldb/test/API/macosx/queues/TestQueues.py
===================================================================
--- lldb/test/API/macosx/queues/TestQueues.py
+++ lldb/test/API/macosx/queues/TestQueues.py
@@ -192,7 +192,6 @@
         user_initiated_thread = lldb.SBThread()
         user_interactive_thread = lldb.SBThread()
         utility_thread = lldb.SBThread()
-        unspecified_thread = lldb.SBThread()
         background_thread = lldb.SBThread()
         for th in process.threads:
             if th.GetName() == "user initiated QoS":
@@ -201,8 +200,6 @@
                 user_interactive_thread = th
             if th.GetName() == "utility QoS":
                 utility_thread = th
-            if th.GetName() == "unspecified QoS":
-                unspecified_thread = th
             if th.GetName() == "background QoS":
                 background_thread = th
 
@@ -213,9 +210,6 @@
             user_interactive_thread.IsValid(),
             "Found user interactive QoS thread")
         self.assertTrue(utility_thread.IsValid(), "Found utility QoS thread")
-        self.assertTrue(
-            unspecified_thread.IsValid(),
-            "Found unspecified QoS thread")
         self.assertTrue(
             background_thread.IsValid(),
             "Found background QoS thread")
@@ -248,16 +242,6 @@
             stream.GetData(), "Utility",
             "utility QoS thread name is valid")
         stream.Clear()
-        self.assertTrue(
-            unspecified_thread.GetInfoItemByPathAsString(
-                "requested_qos.printable_name",
-                stream),
-            "Get QoS printable string for unspecified QoS thread")
-        qosName = stream.GetData()
-        self.assertTrue(
-            qosName == "User Initiated" or qosName == "Default",
-            "unspecified QoS thread name is valid: " + str(qosName))
-        stream.Clear()
         self.assertTrue(
             background_thread.GetInfoItemByPathAsString(
                 "requested_qos.printable_name",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86211.287721.patch
Type: text/x-patch
Size: 2808 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200825/52587921/attachment.bin>