[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

[Harmen Stoppels via Phabricator via lldb-commits]

haampie added a comment.

@gkistanova It's true that this change has lead to more issues I could ever imagine, but I think the link you provided is the last remaining problem.

Pinging @phosek for a similar issue w.r.t. zlib: since https://reviews.llvm.org/D79219 zlib gets disabled on static builds of LLVM.  The reason is `find_package(ZLIB)` finds a shared library, and `check_symbol_exists(compress2 zlib.h HAVE_ZLIB)` tries to statically link to that -- it can't so zlib is disabled. I guess that's a regression too?

What would be the best way forward @phosek? A quick fix for ncurses is to add a simple `check_symbol_exists` test too, but that would in practice just disable ncurses in static builds. And additionally we could find static libs by adding explicit names like `libtinfo.a` to find_library when `LLVM_BUILD_STATIC=ON`. This trick won't help for zlib though, the find_library stuff is hidden inside find_package, and there is no way to target static libs it seems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85820/new/

https://reviews.llvm.org/D85820