[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 24 02:40:46 PDT 2020


labath added a comment.

In D86348#2231094 <https://reviews.llvm.org/D86348#2231094>, @aprantl wrote:

> This looks nice! I'm somewhat suspicious that the new test doesn't specifically test the union case of the old test, but I'm assuming that would still work and your simpler tests covers the same code?

For a while I did want to just delete that union+bitfield test, but I eventually concluded that it is interesting to keep it. This patch keeps the original tests, only it renames it to a less generic name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86348/new/

https://reviews.llvm.org/D86348



More information about the lldb-commits mailing list