[Lldb-commits] [PATCH] D86388: Fix use-after-free in ThreadPlan, and add test.
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Aug 21 23:11:45 PDT 2020
JDevlieghere added inline comments.
================
Comment at: lldb/include/lldb/Target/ThreadPlan.h:603
- Thread *m_thread; // Stores a cached value of the thread, which is set to
- // nullptr when the thread resumes. Don't use this anywhere
- // but ThreadPlan::GetThread().
+ lldb::ThreadSP m_thread_sp; // Stores a cached value of the thread. Don't use
+ // use this anywhere but ThreadPlan::GetThread().
----------------
drive-by nit: since you're touching this, can you make it a Doxygen comment (`///`) above the variable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86388/new/
https://reviews.llvm.org/D86388
More information about the lldb-commits
mailing list