[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

António Afonso via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 21 10:40:19 PDT 2020


aadsm added inline comments.


================
Comment at: lldb/bindings/python/python-typemaps.swig:500
+  }
+};
+
----------------
labath wrote:
> Could you also `= delete` the copy operations to make sure nothing funny happens with those.
The `= delete` is unsupported in SWIG 2, only in 3: http://www.swig.org/Doc3.0/CPlusPlus11.html#CPlusPlus11_defaulted_deleted
Do we really need it, or is there a workaround it, or should we just bump the minimum requirements to SWIG 3?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77480/new/

https://reviews.llvm.org/D77480



More information about the lldb-commits mailing list