[Lldb-commits] [PATCH] D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value

Fri Aug 21 09:49:29 PDT 2020

labath added inline comments.

================
Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_const_value.s:2
+# RUN: llvm-mc -filetype=obj -o %t -triple x86_64-apple-macosx10.15.0 %s
+# RUN: %lldb %t -o "target variable constant" -b | FileCheck %s
+
----------------
shafik wrote:
> aprantl wrote:
> > I think this is missing a REQUIRES: line that checks for an x86 target?
> I did not use that in D85376, is there something different in this case?
All tests using x86 assembly technically require that, but I don't believe we have a bot which is configured to build without that target, so nothing enforces that. I'm pretty sure there are other tests that need this stanza, but don't have it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86311/new/

https://reviews.llvm.org/D86311