[Lldb-commits] [PATCH] D83116: [DWARFYAML] Add support for referencing different abbrev tables.

Fri Aug 21 03:22:12 PDT 2020

Higuoxing requested review of this revision.
Higuoxing added a comment.

Hi @jhenderson

This change is causing build failure on armv7 platform and I've fixed it.

See: http://lab.llvm.org:8011/builders/clang-cmake-armv7-global-isel/builds/10400 and http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/20261

Could you please review this change again? Thanks a lot!

================
Comment at: llvm/lib/ObjectYAML/DWARFYAML.cpp:69
+            errc::invalid_argument,
+            "the ID (%" PRIu64 ") of abbrev table with index %zu has been used "
+            "by abbrev table with index %" PRIu64,
----------------
The build failure is caused by the incorrect format string. `AbbrevTable.index()` returns `size_t` and it was formatted as `%u`. We should use `%zu` here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83116/new/

https://reviews.llvm.org/D83116