[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 20 00:10:08 PDT 2020


wallace accepted this revision.
wallace added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:559-560
         if (!match) {
+          // Breakpad might put a hash of the up to the first page if .text
+          // bytes into the UUID of a minidump. Facebook also has slightly
+          // modified this hash to avoid collisions. Check for UUIDs from the
----------------
I don't understand well the first sentence


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86261/new/

https://reviews.llvm.org/D86261



More information about the lldb-commits mailing list