[Lldb-commits] [lldb] a6eb70c - [lldb] Return empty string from getExtraMakeArgs when not implemented

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 19 17:53:02 PDT 2020


Author: Jonas Devlieghere
Date: 2020-08-19T17:52:50-07:00
New Revision: a6eb70c052da767aef6b041d0db20bdf3a9e06b5

URL: https://github.com/llvm/llvm-project/commit/a6eb70c052da767aef6b041d0db20bdf3a9e06b5
DIFF: https://github.com/llvm/llvm-project/commit/a6eb70c052da767aef6b041d0db20bdf3a9e06b5.diff

LOG: [lldb] Return empty string from getExtraMakeArgs when not implemented

No return statement means the method returns None which breaks a list
comprehension down the line that expects a str instance.

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/builders/builder.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/builders/builder.py b/lldb/packages/Python/lldbsuite/test/builders/builder.py
index 4a8985104874..fbfa86700e22 100644
--- a/lldb/packages/Python/lldbsuite/test/builders/builder.py
+++ b/lldb/packages/Python/lldbsuite/test/builders/builder.py
@@ -25,6 +25,7 @@ def getExtraMakeArgs(self):
         Helper function to return extra argumentsfor the make system. This
         method is meant to be overridden by platform specific builders.
         """
+        return ""
 
     def getArchCFlags(self, architecture):
         """Returns the ARCH_CFLAGS for the make system."""


        


More information about the lldb-commits mailing list