[Lldb-commits] [PATCH] D86235: Fix swig scripts install target name

António Afonso via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 19 13:34:23 PDT 2020


aadsm added a comment.

@JDevlieghere thanks for the quick review, but on the name I mean the actual `finish_swig_python_scripts`, this sounds like a step name and not a component distributed by llvm like `liblldb` ot `lldb-server`. That was the reason at the time I named it `lldb-python-scripts` because it was very clear what was being installed.
Would you be fine with me changing `swig_scripts_target` back to `lldb-python-scripts`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86235/new/

https://reviews.llvm.org/D86235



More information about the lldb-commits mailing list