[Lldb-commits] [PATCH] D86242: [lldb/interpreter] Add REPL-specific init file.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/docs/man/lldb.rst:312
 
 First, it will read the application specific init file whose name is
 ~/.lldbinit followed by a "-" and the name of the current program. This would
----------------
I wonder if we should have the description here, and refer to it from the REPL section. 


================
Comment at: lldb/include/lldb/API/SBCommandInterpreter.h:150
+  void SourceInitFileInHomeDirectory(lldb::SBCommandReturnObject &result,
+                                     bool repl_enabled);
 
----------------
nit: How about `is_repl` as this is not really something you turn on and off? 


================
Comment at: lldb/include/lldb/API/SBCommandInterpreter.h:150
+  void SourceInitFileInHomeDirectory(lldb::SBCommandReturnObject &result,
+                                     bool repl_enabled);
 
----------------
JDevlieghere wrote:
> nit: How about `is_repl` as this is not really something you turn on and off? 
I'd also give it a default argument (`false`). 


================
Comment at: lldb/source/API/SBDebugger.cpp:223
     SBCommandReturnObject result;
-    interp.SourceInitFileInHomeDirectory(result);
+    interp.SourceInitFileInHomeDirectory(result, false);
   } else {
----------------
This can go with the default arg.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86242/new/

https://reviews.llvm.org/D86242