[Lldb-commits] [PATCH] D86237: [lldb] Code sign binaries with entitlements

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added a reviewer: jasonmolenda.
JDevlieghere requested review of this revision.

Binaries need to be code signed to run on device.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D86237

Files:
  lldb/packages/Python/lldbsuite/test/builders/darwin.py
  lldb/packages/Python/lldbsuite/test/make/entitlements.plist


Index: lldb/packages/Python/lldbsuite/test/make/entitlements.plist
===================================================================
--- /dev/null
+++ lldb/packages/Python/lldbsuite/test/make/entitlements.plist
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+    <key>com.apple.security.get-task-allow</key>
+    <true/>
+    <key>com.apple.private.security.no-sandbox</key>
+    <true/>
+</dict>
+</plist>
Index: lldb/packages/Python/lldbsuite/test/builders/darwin.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/builders/darwin.py
+++ lldb/packages/Python/lldbsuite/test/builders/darwin.py
@@ -1,4 +1,5 @@
 import re
+import os
 import subprocess
 
 from .builder import Builder
@@ -53,9 +54,12 @@
         if configuration.dsymutil:
             args['DSYMUTIL'] = configuration.dsymutil
 
-        os, _ = self.getOsAndEnv()
-        if os and os != "macosx":
-            args['CODESIGN'] = 'codesign'
+        operating_system, _ = self.getOsAndEnv()
+        if operating_system and operating_system != "macosx":
+            builder_dir = os.path.dirname(os.path.abspath(__file__))
+            test_dir = os.path.dirname(builder_dir)
+            entitlements = os.path.join(test_dir, 'make', 'entitlements.plist')
+            args['CODESIGN'] = 'codesign --entitlements {}'.format(entitlements)
 
         # Return extra args as a formatted string.
         return ' '.join(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86237.286624.patch
Type: text/x-patch
Size: 1596 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200819/fa9ac5ff/attachment.bin>