[Lldb-commits] [PATCH] D86216: [lldb] Forcefully complete a type when adding typedefs

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: teemperor, shafik.
Herald added a project: LLDB.
labath requested review of this revision.
Herald added a subscriber: JDevlieghere.

This is very similar to D85968 <https://reviews.llvm.org/D85968>, only more elusive to since we were not
adding the typedef type to the relevant DeclContext until D86140 <https://reviews.llvm.org/D86140>, which
meant that the DeclContext was populated (and the relevant assertion
hit) only after importing the type into the expression ast in a
particular way.

I haven't checked whether this situation can be hit in the gmodules
case, but my money is on "yes".


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D86216

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
  lldb/test/Shell/SymbolFile/DWARF/DW_AT_declaration-with-children.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86216.286554.patch
Type: text/x-patch
Size: 8869 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200819/c635317b/attachment-0001.bin>