[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 19 05:38:49 PDT 2020

labath added a comment.

Looking at the dependent patch, I see that you need to conjure up a fake register set to make this work. That works, but doesn't seem entirely optimal. This expedition function doesn't really care about register sets, it just needs a way to get a list of registers. What if we just made the interface return that? (e.g. `ArrayRef<uint32_t> GetExpeditedRegisters()`)

And instead of handing the nullptr specially in the caller, we could just make the default implementation of this function return the first (zeroth) register set...



More information about the lldb-commits mailing list