[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

Wed Aug 19 05:17:35 PDT 2020

labath accepted this revision.
labath added inline comments.

================
Comment at: lldb/packages/Python/lldbsuite/builders/builder.py:201-202
                 self.getCCSpec(compiler),
                 self.getDsymutilSpec(),
+                self.getCodesignSpec(),
                 self.getSDKRootSpec(),
----------------
Instead of a new method for each variable any subclass might want to set it would probably be better to just have an `getExtraMakeArgs` method that each subclass can return whatever it wants. ARCH_CFLAGS is fairly generic, so it may make sense to keep that separate, but DSYMUTIL and CODESIGN (and maybe SDKROOT) sound like they could go into the "extra" category.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85539/new/

https://reviews.llvm.org/D85539