[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

[Harmen Stoppels via Phabricator via lldb-commits]

haampie added inline comments.


================
Comment at: llvm/include/llvm/Config/config.h.cmake:212
 /* Define if the setupterm() function is supported this platform. */
-#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO}
+#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO}
 
----------------
srj wrote:
> srj wrote:
> > In my local build of LLVM, I end up with 
> > 
> > `#define LLVM_ENABLE_TERMINFO 1`
> > 
> > in the generated `config.h` file, even thought I configured LLVM's CMake build with `-D LLVM_ENABLE_TERMINFO=OFF` -- surely this is a bug.
> > 
> (fyi, prior to this commit, the corresponding line was `/* #undef HAVE_TERMINFO */`)
@srj you are completely right, the `find_library` lost its `if (LLVM_ENABLE_TERMINFO)` when the last review comments were addressed. Let me submit a patch asap


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85820/new/

https://reviews.llvm.org/D85820