[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

Steven Johnson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 18 14:26:19 PDT 2020


srj added a comment.

This seems to have injected a link-time dependency on `setupterm` etc. even if you configure CMake with LLVM_ENABLE_TERMINFO=OFF (which was not the case before) -- this is breaking some builds of Halide as a result. (Should the `#idef LLVM_ENABLE_TERMINFO` actually if `#if` instead of `#ifdef`?)

Please consider reverting this change if a fix-forward isn't available soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85820/new/

https://reviews.llvm.org/D85820



More information about the lldb-commits mailing list