[Lldb-commits] [lldb] c1b1868 - [lldb] Make error messages in TestQueues more helpfull

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 19 04:30:57 PDT 2020


Author: Raphael Isemann
Date: 2020-08-19T13:30:31+02:00
New Revision: c1b1868f35bbb4d6e63515c00eb74d5aeac1aecc

URL: https://github.com/llvm/llvm-project/commit/c1b1868f35bbb4d6e63515c00eb74d5aeac1aecc
DIFF: https://github.com/llvm/llvm-project/commit/c1b1868f35bbb4d6e63515c00eb74d5aeac1aecc.diff

LOG: [lldb] Make error messages in TestQueues more helpfull

Added: 
    

Modified: 
    lldb/test/API/macosx/queues/TestQueues.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/macosx/queues/TestQueues.py b/lldb/test/API/macosx/queues/TestQueues.py
index 805ad21a4137..e177daa54fa3 100644
--- a/lldb/test/API/macosx/queues/TestQueues.py
+++ b/lldb/test/API/macosx/queues/TestQueues.py
@@ -226,8 +226,8 @@ def queues(self):
                 "requested_qos.printable_name",
                 stream),
             "Get QoS printable string for user initiated QoS thread")
-        self.assertTrue(
-            stream.GetData() == "User Initiated",
+        self.assertEqual(
+            stream.GetData(), "User Initiated",
             "user initiated QoS thread name is valid")
         stream.Clear()
         self.assertTrue(
@@ -235,8 +235,8 @@ def queues(self):
                 "requested_qos.printable_name",
                 stream),
             "Get QoS printable string for user interactive QoS thread")
-        self.assertTrue(
-            stream.GetData() == "User Interactive",
+        self.assertEqual(
+            stream.GetData(), "User Interactive",
             "user interactive QoS thread name is valid")
         stream.Clear()
         self.assertTrue(
@@ -244,8 +244,8 @@ def queues(self):
                 "requested_qos.printable_name",
                 stream),
             "Get QoS printable string for utility QoS thread")
-        self.assertTrue(
-            stream.GetData() == "Utility",
+        self.assertEqual(
+            stream.GetData(), "Utility",
             "utility QoS thread name is valid")
         stream.Clear()
         self.assertTrue(
@@ -256,15 +256,15 @@ def queues(self):
         qosName = stream.GetData()
         self.assertTrue(
             qosName == "User Initiated" or qosName == "Default",
-            "unspecified QoS thread name is valid")
+            "unspecified QoS thread name is valid: " + str(qosName))
         stream.Clear()
         self.assertTrue(
             background_thread.GetInfoItemByPathAsString(
                 "requested_qos.printable_name",
                 stream),
             "Get QoS printable string for background QoS thread")
-        self.assertTrue(
-            stream.GetData() == "Background",
+        self.assertEqual(
+            stream.GetData(), "Background",
             "background QoS thread name is valid")
 
     @skipIfDarwin # rdar://50379398


        


More information about the lldb-commits mailing list