[Lldb-commits] [PATCH] D86174: [lldb] Convert builders to classes so we can use inheritance to override platform specific methods (NFC)

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 19 04:16:38 PDT 2020


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/packages/Python/lldbsuite/builders/freebsd.py:5-11
+    def buildDsym(self,
+                  sender=None,
+                  architecture=None,
+                  compiler=None,
+                  dictionary=None,
+                  testdir=None):
+        return False
----------------
How about we put this into the base class, and remove all the noop builders?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86174/new/

https://reviews.llvm.org/D86174



More information about the lldb-commits mailing list