[Lldb-commits] [PATCH] D86174: [lldb] Convert builders to classes so we can use inheritance to override platform specific methods

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: LLDB, labath.
Herald added subscribers: teemperor, emaste.
JDevlieghere requested review of this revision.

Use inheritance and a factory method to hand out builders instead of importing the desired module. This has the advantage that the platform specific implementations can override methods as they desire.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D86174

Files:
  lldb/packages/Python/lldbsuite/builders/__init__.py
  lldb/packages/Python/lldbsuite/builders/builder.py
  lldb/packages/Python/lldbsuite/builders/darwin.py
  lldb/packages/Python/lldbsuite/builders/freebsd.py
  lldb/packages/Python/lldbsuite/builders/linux.py
  lldb/packages/Python/lldbsuite/builders/netbsd.py
  lldb/packages/Python/lldbsuite/builders/openbsd.py
  lldb/packages/Python/lldbsuite/builders/win32.py
  lldb/packages/Python/lldbsuite/test/lldbtest.py
  lldb/packages/Python/lldbsuite/test/make/Makefile.rules
  lldb/packages/Python/lldbsuite/test/plugins/builder_base.py
  lldb/packages/Python/lldbsuite/test/plugins/builder_darwin.py
  lldb/packages/Python/lldbsuite/test/plugins/builder_freebsd.py
  lldb/packages/Python/lldbsuite/test/plugins/builder_linux.py
  lldb/packages/Python/lldbsuite/test/plugins/builder_netbsd.py
  lldb/packages/Python/lldbsuite/test/plugins/builder_openbsd.py
  lldb/packages/Python/lldbsuite/test/plugins/builder_win32.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86174.286406.patch
Type: text/x-patch
Size: 28235 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200818/46b4dac4/attachment-0001.bin>