[Lldb-commits] [PATCH] D79699: Add ptrace register access for AArch64 SVE registers

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good, just the cpuinfo detection function could use a bit of improvement.

Thanks for your patience.



================
Comment at: lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_static_config/TestSVERegisters.py:22
+        if configuration.lldb_platform_name:
+            self.runCmd('platform get-file "/proc/cpuinfo" "cpuinfo"')
+            cpuinfo_path = "cpuinfo"
----------------
This will put the file into the CWD, which is in the source tree. This should be `self.getBuildArtifact(cpuinfo)`, and then you don't need the tear down hook.

Also, "platform get-file" (or SBPlatform::Get) should also work on local setups.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79699/new/

https://reviews.llvm.org/D79699