[Lldb-commits] [lldb] 24c74f5 - [lldb] Don't delete orphaned shared modules in SBDebugger::DeleteTarget

[Raphael Isemann via lldb-commits]

Author: Raphael Isemann
Date: 2020-08-17T11:30:56+02:00
New Revision: 24c74f5e8c2cf263dd84292ca5d33ee0890b48dd

URL: https://github.com/llvm/llvm-project/commit/24c74f5e8c2cf263dd84292ca5d33ee0890b48dd
DIFF: https://github.com/llvm/llvm-project/commit/24c74f5e8c2cf263dd84292ca5d33ee0890b48dd.diff

LOG: [lldb] Don't delete orphaned shared modules in SBDebugger::DeleteTarget

In D83876 the consensus seems that LLDB should never deleted orphaned modules
implicitly. However, SBDebugger::DeleteTarget is currently doing exactly that.
This code was added in 753406221b55b95141c8c1239660dc4db4e35ea5 but I don't see
any explanation in the commit, so I think we should delete it.

Reviewed By: clayborg

Differential Revision: https://reviews.llvm.org/D83933

Added: 
    

Modified: 
    lldb/source/API/SBDebugger.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/API/SBDebugger.cpp b/lldb/source/API/SBDebugger.cpp
index 5f62987f37da..b39481c70972 100644
--- a/lldb/source/API/SBDebugger.cpp
+++ b/lldb/source/API/SBDebugger.cpp
@@ -879,8 +879,6 @@ bool SBDebugger::DeleteTarget(lldb::SBTarget &target) {
       result = m_opaque_sp->GetTargetList().DeleteTarget(target_sp);
       target_sp->Destroy();
       target.Clear();
-      const bool mandatory = true;
-      ModuleList::RemoveOrphanSharedModules(mandatory);
     }
   }