[Lldb-commits] [PATCH] D85993: [lldb] Set the access property on member function decls

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 17 01:32:37 PDT 2020


labath added a reviewer: teemperor.
labath added a comment.

Dwarf parser uses `TypeSystemClang::AddMethodToCXXRecordType` instead of this function to create methods (which is why there are no assertions like this when using dwarf). Maybe it would be better to change the pdb parser to use that function instead (as it allows the user to specify not only accessibility, but also other potentially useful properties of the created method -- static, virtual, etc.).

And this function could assert that it is _only_ used for creating free functions ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85993/new/

https://reviews.llvm.org/D85993



More information about the lldb-commits mailing list