[Lldb-commits] [PATCH] D85542: lldbutil: add a retry mechanism for the ios simulator

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Aug 7 12:31:11 PDT 2020

aprantl added inline comments.

Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:824
+    while (retry and error.Fail() and
+           isinstance(error.GetCString(), six.string_types) and
+           "Unable to boot the Simulator" in error.GetCString()):
JDevlieghere wrote:
> Why is this necessary? Is there an error case where `error.GetCString` is not a python string? If so we should probably factor this out in a function and do the `if sys.version_info.major == 2: str.decode('utf-8', 'replace')` trick instead because otherwise the retry won't kick in.
It may be `None`. So I guess we could write `and error.GetCString()`? I just didn't want to crash on unexpected input.



More information about the lldb-commits mailing list