[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

[Frederic Riss via Phabricator via lldb-commits]

friss added a comment.

This LGTM. The only comment I had is about a comment you added on preexisting code:



================
Comment at: lldb/source/Commands/CommandObjectThread.cpp:486-490
+      // NonStopMode runs all threads down in the ProcessPlugin layer, but
+      // at this level we need to pretend we are actually only running this
+      // thread.  So functionally it does the same thing as
+      // GetSteppingRunsAllThreads.  So it overrides the runs all threads
+      // setting.
----------------
It feels like the last sentence shouldn't be there.

Also, the comment doesn't explain *why* "we need to pretend". 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85265/new/

https://reviews.llvm.org/D85265