[Lldb-commits] [PATCH] D85243: Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:558
+          "arm64e-apple-ios-simulator", "arm64-apple-ios-simulator",
+              "x86_64-apple-ios-simulator", "x86_64h-apple-ios-simulator",
+#else
----------------
vsk wrote:
> aprantl wrote:
> > vsk wrote:
> > > Can we get into a bad state here when initializing lldb on an embedded device?
> > Good question. I think the pragmatic answer here is that we won't encounter simulator binaries on an embedded device and that the platform will refuse to launch a simulator if one doesn't exist.
> All the same, just in case we need to introduce mac-specific code in the future, it may be more convenient to write this as `#if TARGET_OS_MAC == 1 && TARGET_CPU_ARM == 1` (hope I've spelled that correctly!)
Thanks! In case you didn't already notice, I just wanted to point out that I merely moved this code from one file to another in this commit. That said, that's not an excuse to not improve it, of course!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85243/new/

https://reviews.llvm.org/D85243