[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

Sterling Augustine via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 6 10:26:00 PDT 2020


saugustine added a comment.

This change has a subtle isse with wattr_get and friends: saved_opts isn't actually used, and the documentation for them says to always pass a nullptr. "The parameter opts is reserved for future use, applications must supply a null pointer."

I fixed it in 9dbdaea9a0e6f58417b5bd8980e7ea6723fd1783 <https://reviews.llvm.org/rG9dbdaea9a0e6f58417b5bd8980e7ea6723fd1783>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85145/new/

https://reviews.llvm.org/D85145



More information about the lldb-commits mailing list