[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 5 23:47:57 PDT 2020

teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

Sorry was OOO.

The source code is user input, so you can have anything in it. LLDB will happily read and return any file contents as long as it matches the source path. Like, create a test.cpp, compile it, then just copy over some binary file to the source path. Not that we should do some complicated error handling in this case, but as long as we don't assert and end the whole debug session it's IMHO fine. This LGTM to me now, thanks for working on this!

In D85145#2192991 <https://reviews.llvm.org/D85145#2192991>, @llunak wrote:

> I find some of the StringRef APIs flawed though: consume_front() returns true on success, but consumeInteger() returns false; consume_front() modifies the object, but drop_front() doesn't.

Yeah I had the same realization when I typed the example.




More information about the lldb-commits mailing list