[Lldb-commits] [PATCH] D85358: Correctly detect legacy iOS simulator Mach-O objectfiles

[Frederic Riss via Phabricator via lldb-commits]

friss added inline comments.


================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5029-5030
+      // Disambiguate legacy simulator platforms.
+      if (base_triple.getArch() == llvm::Triple::x86_64 ||
+          base_triple.getArch() == llvm::Triple::x86) {
+        // The combination of legacy LC_VERSION_MIN load command and
----------------
It seems like this will also mark a binary with `LC_VERSION_MIN_MACOSX` as a simulator binary?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85358/new/

https://reviews.llvm.org/D85358