[Lldb-commits] [PATCH] D85258: [test] Use realpath consistently for test root file paths.

[Jordan Rupprecht via Phabricator via lldb-commits]

rupprecht marked an inline comment as done.
rupprecht added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:499
         # /abs/path/to/packages/group/subdir/mytest.py -> group/subdir
-        rel_prefix = test_file[len(os.environ["LLDB_TEST_SRC"]) + 1:]
-        return os.path.dirname(rel_prefix)
+        lldb_test_src = os.environ["LLDB_TEST_SRC"]
+        if not test_file.startswith(lldb_test_src):
----------------
JDevlieghere wrote:
> While you are here... can you change this to pass the source directory trough the `configuration`?
Absolutely, but in the spirit of small/isolated changes, split off as D85322.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85258/new/

https://reviews.llvm.org/D85258