[Lldb-commits] [lldb] c7be982 - [lldb][gui] move TestGuiBasicDebug.py to lldb/test and update it

[Luboš Luňák via lldb-commits]

Author: Luboš Luňák
Date: 2020-08-05T09:51:13+02:00
New Revision: c7be982c836cdaf7b1ef303d903e6a3de2eb4a34

URL: https://github.com/llvm/llvm-project/commit/c7be982c836cdaf7b1ef303d903e6a3de2eb4a34
DIFF: https://github.com/llvm/llvm-project/commit/c7be982c836cdaf7b1ef303d903e6a3de2eb4a34.diff

LOG: [lldb][gui] move TestGuiBasicDebug.py to lldb/test and update it

Between the time it was created and it was pushed upstream,
99451b4453688a94c6014cac233d371ab4cc342d has moved the existing
gui gui tests to lldb/test, so move this one too.
And update it to contain TestGuiBasic.py changes since the time
when it was based on that test.

Differential Revision: https://reviews.llvm.org/D85106

Added: 
    lldb/test/API/commands/gui/basicdebug/Makefile
    lldb/test/API/commands/gui/basicdebug/TestGuiBasicDebug.py
    lldb/test/API/commands/gui/basicdebug/func.c
    lldb/test/API/commands/gui/basicdebug/main.c

Modified: 
    

Removed: 
    lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/Makefile
    lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py
    lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/func.c
    lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/main.c


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/Makefile b/lldb/test/API/commands/gui/basicdebug/Makefile
similarity index 100%
rename from lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/Makefile
rename to lldb/test/API/commands/gui/basicdebug/Makefile

diff  --git a/lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py b/lldb/test/API/commands/gui/basicdebug/TestGuiBasicDebug.py
similarity index 83%
rename from lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py
rename to lldb/test/API/commands/gui/basicdebug/TestGuiBasicDebug.py
index 54c763fd2afc..76d9d3bdc463 100644
--- a/lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py
+++ b/lldb/test/API/commands/gui/basicdebug/TestGuiBasicDebug.py
@@ -11,7 +11,11 @@ class TestGuiBasicDebugCommandTest(PExpectTest):
 
     mydir = TestBase.compute_mydir(__file__)
 
+    # PExpect uses many timeouts internally and doesn't play well
+    # under ASAN on a loaded machine..
+    @skipIfAsan
     @skipIfCursesSupportMissing
+    @skipIfRemote # "run" command will not work correctly for remote debug
     def test_gui(self):
         self.build()
 
@@ -39,4 +43,8 @@ def test_gui(self):
         self.child.send("n") # step over
         self.child.expect("return 0;[^\r\n]+<<< Thread 1: step over")
 
+        # Press escape to quit the gui
+        self.child.send(escape_key)
+
+        self.expect_prompt()
         self.quit()

diff  --git a/lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/func.c b/lldb/test/API/commands/gui/basicdebug/func.c
similarity index 100%
rename from lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/func.c
rename to lldb/test/API/commands/gui/basicdebug/func.c

diff  --git a/lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/main.c b/lldb/test/API/commands/gui/basicdebug/main.c
similarity index 100%
rename from lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/main.c
rename to lldb/test/API/commands/gui/basicdebug/main.c