[Lldb-commits] [PATCH] D85243: [WIP] Factor out common code from the iPhone/AppleTV/WatchOS simulator platform plugins. (NFC)

[Vedant Kumar via Phabricator via lldb-commits]

vsk added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:313
+#if defined(__APPLE__)
+      // Only accept "unknown" for the vendor if the host is Apple and it
+      // "unknown" wasn't specified (it was just returned because it was NOT
----------------
s/it$/if$/


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:558
+          "arm64e-apple-ios-simulator", "arm64-apple-ios-simulator",
+              "x86_64-apple-ios-simulator", "x86_64h-apple-ios-simulator",
+#else
----------------
Can we get into a bad state here when initializing lldb on an embedded device?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85243/new/

https://reviews.llvm.org/D85243