[Lldb-commits] [PATCH] D84576: Fix debugserver's qProcessInfo reporting of maccatalyst binaries

[Frederic Riss via Phabricator via lldb-commits]

friss added a comment.

This looks good outside of 2 cross-platform issues in the tests themselves.



================
Comment at: lldb/test/API/macosx/macCatalyst/TestMacCatalyst.py:27
+        self.expect("image list -t -b",
+                    patterns=["x86_64.*-apple-ios.*-macabi a\.out"])
+        self.expect("fr v s", "Hello macCatalyst")
----------------
hardcoded architecture and no architecture decorator.


================
Comment at: lldb/test/API/macosx/macCatalystAppMacOSFramework/TestMacCatalystAppWithMacOSFramework.py:27-28
+        self.expect("image list -t -b",
+                    patterns=["x86_64.*-apple-ios.*-macabi a\.out",
+                              "x86_64.*-apple-macosx.* libfoo.dylib[^(]"])
+        self.expect("fr v s", "Hello macCatalyst")
----------------
ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84576/new/

https://reviews.llvm.org/D84576