[Lldb-commits] [PATCH] D85106: Move TestGuiBasicDebug.py to lldb/test and update it

[Luboš Luňák via Phabricator via lldb-commits]

llunak created this revision.
llunak added a reviewer: clayborg.
llunak requested review of this revision.

Between the time it was created and it was pushed upstream, 99451b4453688a94c6014cac233d371ab4cc342d <https://reviews.llvm.org/rG99451b4453688a94c6014cac233d371ab4cc342d> has moved the existing gui gui tests to lldb/test, so move this one too.
And update it to contain TestGuiBasic.py changes since the time when it was based on that test.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D85106

Files:
  lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/Makefile
  lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py
  lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/func.c
  lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/main.c
  lldb/test/API/commands/gui/basicdebug/Makefile
  lldb/test/API/commands/gui/basicdebug/TestGuiBasicDebug.py
  lldb/test/API/commands/gui/basicdebug/func.c
  lldb/test/API/commands/gui/basicdebug/main.c


Index: lldb/test/API/commands/gui/basicdebug/TestGuiBasicDebug.py
===================================================================
--- lldb/test/API/commands/gui/basicdebug/TestGuiBasicDebug.py
+++ lldb/test/API/commands/gui/basicdebug/TestGuiBasicDebug.py
@@ -11,7 +11,11 @@
 
     mydir = TestBase.compute_mydir(__file__)
 
+    # PExpect uses many timeouts internally and doesn't play well
+    # under ASAN on a loaded machine..
+    @skipIfAsan
     @skipIfCursesSupportMissing
+    @skipIfRemote # "run" command will not work correctly for remote debug
     def test_gui(self):
         self.build()
 
@@ -39,4 +43,8 @@
         self.child.send("n") # step over
         self.child.expect("return 0;[^\r\n]+<<< Thread 1: step over")
 
+        # Press escape to quit the gui
+        self.child.send(escape_key)
+
+        self.expect_prompt()
         self.quit()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D85106.282505.patch
Type: text/x-patch
Size: 874 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200803/f05807e0/attachment-0001.bin>