[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error

[Aaron Smith via Phabricator via lldb-commits]

asmith accepted this revision.
asmith added a comment.
This revision is now accepted and ready to land.

LGTM.

Some changes for grammar to the title -- "[lldb/Process/Windows] Attempting to kill an exited/detached process is not an error"

A little more description would be helpful for others. Here's a suggestion --

"The lldb test-suite on Windows reports a 'CLEANUP ERROR' when attempting to kill an exited/detached process. This change makes ProcessWindows consistent with the other processes which only log the error. After this change a large number of 'CLEANUP ERROR' messages are now removed."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84957/new/

https://reviews.llvm.org/D84957